Make NonRetryableError non-abstract in types #2932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skye-31
reviewed
Oct 15, 2024
LuisDuarte1
force-pushed
the
lduarte/fix-nonretryableerror-abstract
branch
from
91c02cd to
8f71b39
Compare
a-robinson
approved these changes
Oct 15, 2024
Basically, we won't get NonRetryableError serialization done properly because we would have to implement our own Error Serializer for this which might not be worth it, at least for launch. Even if we fix this later, it's okay to let users throw a raw NonRetryableError anyway.
LuisDuarte1
force-pushed
the
lduarte/fix-nonretryableerror-abstract
branch
from
8f71b39 to
bfb7fce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, we won't get NonRetryableError serialization done properly because we would have to implement our own Error Serializer for this which might not be worth it, at least for launch. Even if we fix this later, it's okay to let users throw a raw NonRetryableError anyway.