[o11y] Fix incorrect R2 span names, add initial cache, memory-cache user spans #2829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhanau
changed the title
fhanau
changed the title
Splitting this off of #2799, which will take some more work.
fhanau
force-pushed
the
felix/span-fixes
branch
from
ca7a0b8 to
5a03420
Compare
tewaro
approved these changes
Sep 30, 2024
mikea
approved these changes
Sep 30, 2024
src/workerd/api/cache.c++
Outdated
| @@ -518,7 +518,8 @@ jsg::Promise<bool> Cache::delete_( | |||
|
|
|||
| kj::Own<kj::HttpClient> Cache::getHttpClient( | |||
| IoContext& context, kj::Maybe<kj::String> cfBlobJson, kj::ConstString operationName) { | |||
There was a problem hiding this comment.
I think we should make operationName a LiteralConstString. Would this also simplify the next line?
There was a problem hiding this comment.
Thank you for the suggestion, that does make things easier! I tried to get the ConstString stuff right and the approach I had was memory safe at least but this is certainly more elegant/saves a memory allocation.
fhanau
force-pushed
the
felix/span-fixes
branch
from
5a03420 to
82d0e98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting this off of #2799, which will take some more work.