Revert "improve encodeBase64Url performance (#2774)" #2776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b3d98e0.
fhanau
approved these changes
Sep 23, 2024
jasnell
approved these changes
Sep 23, 2024
jclee
reviewed
Sep 23, 2024
| auto actual_length = simdutf::binary_to_base64( | ||
| bytes.asChars().begin(), bytes.size(), output.asChars().begin(), simdutf::base64_url); | ||
| KJ_ASSERT(expected_length == actual_length); | ||
| return kj::String(kj::mv(output)); |
There was a problem hiding this comment.
Seems likely this might be the issue? I think kj::String has an internal assert to require that any string pointer content be null-terminated. Might be able to fix it by allocating a slightly bigger array and adding the terminator before passing to kj::String.
There was a problem hiding this comment.
You're absolutely right. Yes, I'll follow up in a new pull-request to fix this. Let's fix edgeworker first!
jclee
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b3d98e0.
I'll follow up on a different PR to fix edgeworker related tests.