Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use LLD on Linux #2762

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Always use LLD on Linux #2762

merged 1 commit into from
Sep 20, 2024

Conversation

npaun
Copy link
Member

@npaun npaun commented Sep 20, 2024

Currently, we strongly recommend clang's lld but suggest it "may" be possible to use GNU ld. GNU ld worked in the past but was slow. It currently doesn't work at all due to some errors relating to missing symbols in chromium zlib.

This PR simplifies things by requiring clang lld, and explicitly using it for builds. If a user can install clang, it's simpler to just install lld as well, instead of mixing things.

@npaun npaun requested review from mikea and fhanau September 20, 2024 20:00
@npaun npaun requested review from a team as code owners September 20, 2024 20:00
@npaun npaun merged commit 80bad7f into main Sep 20, 2024
14 checks passed
@npaun npaun deleted the npaun/use-lld branch September 20, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants