Add Sqlite test for read/write row counters for large rows #2718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
reviewed
Sep 17, 2024
|
|
||
| db.run("CREATE TABLE large_things (id INTEGER PRIMARY KEY, large_value TEXT)"); | ||
|
|
||
| // SQLite's default page size is 4096 bytes |
There was a problem hiding this comment.
Can you add an assertion for the default page size? It seems pragma_page_size() is available.
justin-mp
reviewed
Sep 17, 2024
| @@ -663,6 +663,36 @@ KJ_TEST("SQLite write row counters (basic)") { | |||
| } | |||
| } | |||
|
|
|||
| KJ_TEST("SQLite read/write row counters (large row insert)") { | |||
There was a problem hiding this comment.
It would be good to comment why we have this test (either in the commit message or with a comment here).
I believe it's to make sure that extra page reads aren't included in the row count.
Does it also make sense to have more than one row for this test? I don't know how big rows are actually stored in SQLite.
There was a problem hiding this comment.
Big rows are stored in what is called overflow pages - https://www.sqlite.org/fileformat2.html#ovflpgs
I don't think having multiple rows in the test is going to give us any new information.
Will add the comment
shrima-cf
force-pushed
the
shrima/add-sqlite_test_large_readwrite
branch
from
6741446 to
e8559d7
Compare
shrima-cf
force-pushed
the
shrima/add-sqlite_test_large_readwrite
branch
from
e8559d7 to
a33e1a8
Compare
justin-mp
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.