Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable linter for module.ts #2653

Merged
merged 1 commit into from
Sep 4, 2024
Merged

enable linter for module.ts #2653

merged 1 commit into from
Sep 4, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Sep 4, 2024 •
edited
Loading

We no longer need to disable linters for files that use URL or queueMicrotask()

@anonrig anonrig requested a review from jasnell September 4, 2024 12:57
@anonrig anonrig requested review from a team as code owners September 4, 2024 12:57
@anonrig anonrig requested a review from vickykont September 4, 2024 12:57
@anonrig anonrig force-pushed the yagiz/fix-module-ts branch from cbafc88 to cca4578 Compare September 4, 2024 13:14
@anonrig
Copy link
Member Author

anonrig commented Sep 4, 2024

I had to force push. I added dom as the library to tsconfig to enable types for URL. This come with a caveat (or a benefit depending on your pov.), where webcrypto types are also implemented.

@anonrig anonrig force-pushed the yagiz/fix-module-ts branch from cca4578 to c298134 Compare September 4, 2024 15:13
@anonrig anonrig force-pushed the yagiz/fix-module-ts branch from c298134 to 9e0ad38 Compare September 4, 2024 15:16
npaun
npaun approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@npaun npaun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@anonrig anonrig merged commit 4ce3a8d into main Sep 4, 2024
13 checks passed
@anonrig anonrig deleted the yagiz/fix-module-ts branch September 4, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhanau fhanau fhanau approved these changes

@npaun npaun npaun approved these changes

@jasnell jasnell jasnell approved these changes

@vickykont vickykont Awaiting requested review from vickykont vickykont is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anonrig @jasnell @npaun @fhanau