[build] Refactor zlib configuration #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
approved these changes
Aug 28, 2024
|
Seems like something got bungled with visibility? |
|
It's including system zlib headers instead of the headers here when dropping the |
fhanau
force-pushed
the
felix/gn-zlib-cleanup
branch
from
16f722e to
49c53fc
Compare
npaun
approved these changes
Aug 28, 2024
- Drop visibility attribute, only zlib library itself needs to be visible - Drop support for unsupported architectures, add target_compatible_with for arch-specific targets - Fold up x86_defines
fhanau
force-pushed
the
felix/gn-zlib-cleanup
branch
from
49c53fc to
eb520b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will make another PR that switches to using
local_definesin the afternoon.