Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix R2 wildcard etag parsing #2611

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Fix R2 wildcard etag parsing #2611

merged 1 commit into from
Sep 10, 2024

Conversation

harshal317
Copy link
Contributor

This commit addresses issue #2572

@harshal317 harshal317 requested review from a team as code owners August 27, 2024 14:27
@harshal317 harshal317 requested review from dom96 and tewaro August 27, 2024 14:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 27, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@harshal317
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Aug 27, 2024
@github-actions
@harshal317 has signed the CLA in #2611
01101bc
jasnell
jasnell reviewed Aug 27, 2024
View reviewed changes
src/workerd/api/r2-test.js Outdated Show resolved Hide resolved
jasnell
jasnell reviewed Aug 27, 2024
View reviewed changes
src/workerd/api/r2-test.js Outdated Show resolved Hide resolved
jasnell
jasnell reviewed Aug 27, 2024
View reviewed changes
src/workerd/api/r2-test.js Outdated Show resolved Hide resolved
jasnell
jasnell reviewed Aug 27, 2024
View reviewed changes
src/workerd/api/r2-test.js Outdated Show resolved Hide resolved
jasnell
jasnell reviewed Aug 27, 2024
View reviewed changes
src/workerd/api/r2-test.js Outdated Show resolved Hide resolved
jasnell
jasnell reviewed Aug 27, 2024
View reviewed changes
src/workerd/api/r2-test.js Outdated Show resolved Hide resolved
anonrig
anonrig reviewed Aug 27, 2024
View reviewed changes
src/workerd/api/r2-test.js Outdated Show resolved Hide resolved
@harshal317 harshal317 force-pushed the harshal/fix-etags branch 2 times, most recently from 5b0e8ad to 0569aa8 Compare August 27, 2024 17:19
@harshal317 harshal317 closed this Aug 28, 2024
@harshal317 harshal317 reopened this Aug 28, 2024
@harshal317
Copy link
Contributor Author

Oops thought maybe clicking close would give me an option to merge.

@harshal317
Copy link
Contributor Author

@jasnell @anonrig should I get a review from anyone else? If not, could one of you help me with merging this

@jasnell
Copy link
Member

jasnell commented Sep 5, 2024

Have you run an internal CI job with this update to verify everything works internally? If so, this should be ready to land. If not, let's do that first.

@harshal317
Copy link
Contributor Author

Have you run an internal CI job with this update to verify everything works internally? If so, this should be ready to land. If not, let's do that first.

I hadn't but I've done so now. Should be good if you could help w/ kicking these builds again and merging 🙏

@harshal317
Fix R2 wildcard etag parsing
ba2e62c 
This commit addresses issue cloudflare#2572
@jasnell jasnell merged commit da2d274 into cloudflare:main Sep 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@jasnell jasnell jasnell approved these changes

@dom96 dom96 Awaiting requested review from dom96 dom96 is a code owner automatically assigned from cloudflare/workers-runtime-1

@tewaro tewaro Awaiting requested review from tewaro tewaro is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshal317 @jasnell @anonrig