improve nodejs buffer base64 and base64url performance #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
Aug 16, 2024
anonrig
force-pushed
the
yagiz/improve-buffer-tostring
branch
from
debd3f5 to
bfdf13a
Compare
npaun
approved these changes
Aug 16, 2024
jasnell
approved these changes
Aug 16, 2024
|
LGTM – I was looking at kj::encodeBase64 a few days ago not even based on performance but since it performs excessive memory allocations. It should probably be optimized still but this change should fix any performance issues for the JS APIs. |
mikea
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the performance of base64 and base64url conversion from binary. Applies to
buffer.toString('base64')andbuffer.toString('base64url')