Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove lto clang override #254

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Conversation

mikea
Copy link
Collaborator

@mikea mikea commented Jan 6, 2023

tcmalloc doesn't build with clang-15 because it matches compiler against "clang" string and decides it is being built by gcc. (you can argue it is bazel's problem)

There's no better way but to symlink /usr/bin/clang and clang++ to recent clang version.

tcmalloc doesn't build with clang-15 because it matches compiler
against "clang" string and decides it is being built by gcc.
(you can argue it is bazel's problem)

There's no better way but to symlink /usr/bin/clang and clang++
to recent clang version.
@mikea mikea requested review from jasnell and kentonv January 6, 2023 18:51
Copy link
Member

@kentonv kentonv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

Is this something we can solve with a custom "toolchain"?

@mikea mikea merged commit 2ed6f28 into main Jan 9, 2023
@mikea mikea deleted the maizatskyi/2023-01-06-tcmalloc-clang-15 branch January 9, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants