Tidy up pyodide bundle API #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
force-pushed
the
hoodmane/tidy-pyodide-bundle-api
branch
from
dcefafc to
6bb9c80
Compare
dom96
approved these changes
Aug 9, 2024
kentonv
reviewed
Aug 9, 2024
kentonv
reviewed
Aug 9, 2024
hoodmane
force-pushed
the
hoodmane/tidy-pyodide-bundle-api
branch
5 times, most recently
from
ab2d9f2 to
163e76b
Compare
This adds a Mutex around the bundleReaders map and makes `getPyodideBundle` return a Maybe<bundle> rather than asserting that the bundle is defined. This means we can get rid of `hasPyodideBundle` in favor of checking whether `getPyodideBundle` returns `none`.
hoodmane
force-pushed
the
hoodmane/tidy-pyodide-bundle-api
branch
from
163e76b to
e4d0258
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Mutex around the bundleReaders map and makes
getPyodideBundlereturn a Maybe rather than asserting that the bundle is defined. This means we can get rid ofhasPyodideBundlein favor of checking whethergetPyodideBundlereturnsnone.