Implement rsa toPem, toDer, and fromJwk utilities #2389

jasnell · 2024-07-12T16:08:09Z

Separating out more of the node.js crypto key handling support. There's a lot to do with all this so I'm piecing it out into separate PRs that individually are easier to review. This adds methods but does not add the stuff that uses it yet. Tests for these individual pieces will also be added separately. A fair amount of this is adapted from https://github.com/nodejs/node/blob/main/src/crypto/crypto_keys.cc

src/workerd/api/crypto/rsa.h

jasnell · 2024-07-12T16:42:58Z

src/workerd/api/crypto/rsa.c++

+  if (result.error != simdutf::SUCCESS) return kj::none;
+  KJ_ASSERT(result.count <= size);
+  return buf.first(result.count).attach(kj::mv(buf));
+}


Reviewer note: This is a more efficient alternative to the existing base64 url decoding method we have based on kj::decodeBase64. This one follows the standard forgiving base64 decode algorithm defined by whatwg specs. Soon I expect this to be moved out of this rsa.c++ file and into a shared location.

src/workerd/api/crypto/impl.c++

src/workerd/api/crypto/rsa.c++

Implement rsa toPem, toDer, and fromJwk utilities

c60fdd7

jasnell requested review from garrettgu10 and fhanau July 12, 2024 16:08

jasnell requested review from a team as code owners July 12, 2024 16:08

jasnell commented Jul 12, 2024

View reviewed changes

src/workerd/api/crypto/rsa.h Outdated Show resolved Hide resolved

Update src/workerd/api/crypto/rsa.h

30a2819

jasnell added nodejs compat api crypto frameworks c++ labels Jul 12, 2024

jasnell commented Jul 12, 2024

View reviewed changes

jasnell requested a review from dom96 July 15, 2024 15:12