-
Notifications
You must be signed in to change notification settings - Fork 358
Add new impliedByAfterDate annotation to compatibility-date #2332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
39075db
to
5bc0405
Compare
To confirm, what this lets us then provide is:
...allowing us to maintain existing behavior, and provide an explicit opt-in (via a compatibility date) |
Yes, that's exactly it @irvinebroque |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good but can we add a test to compatibility-date-test.c++
? Can base the test around the nodejs_compat_v2 flag specifically.
5bc0405
to
8634bbe
Compare
Test added. experimental check removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't review the c++ code, but the tests look exactly like what I would expect. I just have some minor product comments.
The new annotation allows us to specify that a compatibility flag is implied if the named other flag is enabled, but only at the specified compatibility date or later. This will be used, for instance, to specify that `nodejs_compat_v2` is implied on by `nodejs_compat` after a given date.
754a36e
to
27be8f3
Compare
The new annotation allows us to specify that a compatibility flag is implied if the named other flag is enabled, but only at the specified compatibility date or later. If the flag is marked experimental and experimental flags are not allowed, or if the flag is explicitly turned off, the annotation will not apply.
This will be used, for instance, to specify that
nodejs_compat_v2
is implied on bynodejs_compat
after a given date.