Run test imports at top level, fix pydantic and numpy imports #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettgu10
force-pushed
the
ggu/top-level-import-tests
branch
from
89d8b61 to
7ba06c2
Compare
dom96
approved these changes
Jun 24, 2024
garrettgu10
changed the title
garrettgu10
changed the title
ns476
pushed a commit
to ns476/workerd
that referenced
this pull request
Aug 2, 2024
…lare#2324) * Run test imports at top level * Fix the problem --------- Co-authored-by: Hood Chatham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing stuff within a
test()function does not invoke the top-level entropy patches we implemented, so this change should make our testing much more complete.Should reproduce cloudflare/python-workers-examples#9.