Fix UAF in InputGate::Waiter #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a critical section completes with leftover waiters, they are reparented such that the waiters are now waiting on the parent scope. Before this commit, this did not correctly update the `gate` reference in the waiter. This commit also fixes 2 other reparenting bugs, and adds additional test coverage for reparenting: * Ensures that reparenting works with multiple layers of nested critical sections, by skipping already reparented critical sections in the family hierarchy. * Fixes bug when reparenting waiters for nested critical sections, where they were being removed from the incorrect list.
kentonv
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a critical section completes with leftover waiters, they are reparented such that the waiters are now waiting on the parent scope. Before this commit, this did not correctly update the
gatereference in the waiter.This commit also fixes 2 other reparenting bugs, and adds additional test coverage for reparenting:
(@xortive wrote this commit, and the above text.)