Skip to content

Initial Migration of Pyodide Glue Code to Typescript #2258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2024
Merged

Initial Migration of Pyodide Glue Code to Typescript #2258

merged 1 commit into from
Jun 13, 2024

Conversation

garrettgu10
Copy link
Contributor

@garrettgu10 garrettgu10 commented Jun 11, 2024 •
edited
Loading

This is initial scaffolding with all files marked with ts-ignore. More follow-up PRs will come with actual TypeScript.

@garrettgu10 garrettgu10 requested review from a team as code owners June 11, 2024 20:46
@garrettgu10 garrettgu10 requested review from fhanau and jp4a50 June 11, 2024 20:46
@garrettgu10 garrettgu10 marked this pull request as draft June 11, 2024 20:46
@garrettgu10 garrettgu10 force-pushed the ggu/pyodide-typescript branch from 5eb7b3b to 50b6858 Compare June 11, 2024 21:03
@garrettgu10 garrettgu10 marked this pull request as ready for review June 11, 2024 21:07
@garrettgu10 garrettgu10 force-pushed the ggu/pyodide-typescript branch from 50b6858 to d9c5fb5 Compare June 11, 2024 21:08
@garrettgu10 garrettgu10 requested a review from dom96 June 11, 2024 21:08
@garrettgu10 garrettgu10 force-pushed the ggu/pyodide-typescript branch from d9c5fb5 to 37abd6f Compare June 11, 2024 21:11
@garrettgu10 garrettgu10 force-pushed the ggu/pyodide-typescript branch from 37abd6f to ce39b15 Compare June 12, 2024 15:12
@garrettgu10 garrettgu10 changed the title Migrate Pyodide Glue Code to Typescript Initial Migration of Pyodide Glue Code to Typescript Jun 12, 2024
@garrettgu10 garrettgu10 merged commit f8d4977 into main Jun 13, 2024
9 of 10 checks passed
garrettgu10 added a commit that referenced this pull request Jun 13, 2024
@garrettgu10
Revert "Add TypeScript scaffolding & ts-ignore everything (#2258)"
df240fa 
This reverts commit f8d4977.
@garrettgu10 garrettgu10 mentioned this pull request Jun 13, 2024
Merged
garrettgu10 added a commit that referenced this pull request Jun 14, 2024
@garrettgu10
Revert "Add TypeScript scaffolding & ts-ignore everything (#2258)" (#…
1f9eaa6 
…2267)

This reverts commit f8d4977.
garrettgu10 added a commit that referenced this pull request Jun 14, 2024
@garrettgu10
Revert "Revert "Add TypeScript scaffolding & ts-ignore everything (#2258
49ce3d3 
)" (#…"

This reverts commit 1f9eaa6.
garrettgu10 added a commit that referenced this pull request Jun 14, 2024
@garrettgu10
Revert "Revert "Initial Migration of Pyodide Glue Code to Typescript"" (
3f82a1b 
#2272)

* Revert "Revert "Add TypeScript scaffolding & ts-ignore everything (#2258)" (#…"

This reverts commit 1f9eaa6.

* Fix Windows build for Pyodide TypeScript
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@fhanau fhanau Awaiting requested review from fhanau fhanau is a code owner automatically assigned from cloudflare/workers-runtime-1

@jp4a50 jp4a50 Awaiting requested review from jp4a50 jp4a50 is a code owner automatically assigned from cloudflare/workers-runtime-1

@dom96 dom96 Awaiting requested review from dom96

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garrettgu10 @jasnell