Fixup regression in socket api #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A regression was introduced in the socket API with the recent additional of the fetch standard url compat flag. Fixes: #2232
vickykont
approved these changes
Jun 7, 2024
dom96
reviewed
Jun 7, 2024
| // TODO(cleanup): The jsRequest here appears to only be used to serialize the | ||
| // cf blob json, which seems quite wasteful. We ought to be able to avoid the | ||
| // extra allocations and work here. | ||
| auto jsRequest = Request::constructor(js, kj::str("tcp://", addressStr), kj::none); |
There was a problem hiding this comment.
Do make sure this works with the old compat dates too (though hopefully our test suite will test that)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression was introduced in the socket API with the recent additional of the fetch standard url compat flag.
Fixes: #2232