-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sendBatch definition to @cloudflare/workers-types #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
a-robinson
reviewed
Dec 13, 2022
mtlemilio
force-pushed
the
queues-sendbatch
branch
from
December 13, 2022 20:16
fe148c3
to
6f23757
Compare
I have read the CLA Document and I hereby sign the CLA |
mtlemilio
force-pushed
the
queues-sendbatch
branch
from
December 13, 2022 20:22
6f23757
to
a21264f
Compare
a-robinson
reviewed
Dec 13, 2022
a-robinson
reviewed
Dec 13, 2022
This commit adds relevant docstring to sendBatch method in Queues API, which was previously not supported.
mtlemilio
force-pushed
the
queues-sendbatch
branch
from
December 14, 2022 00:31
a21264f
to
13b7493
Compare
a-robinson
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM although I don't know if we should be referring to the input as an array anymore. Thanks for putting up with the comments!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds relevant docstring to sendBatch method in Queues API, which was previously not supported.