Skip to content

fix(node:buffer): add missing atob and btoa exports #2199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2024

Conversation

IgorMinar
Copy link
Contributor

@IgorMinar IgorMinar requested a review from jasnell May 31, 2024 03:10
@IgorMinar IgorMinar requested review from a team as code owners May 31, 2024 03:10
@IgorMinar IgorMinar requested a review from hoodmane May 31, 2024 03:10
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth going ahead and including Blob here too

@IgorMinar IgorMinar force-pushed the fix/node-buffer-exports branch from f0a4da3 to 543a3fa Compare May 31, 2024 03:21
@IgorMinar
Copy link
Contributor Author

@jasnell good catch. added.

@jasnell
Copy link
Member

jasnell commented May 31, 2024

@IgorMinar ... can I ask you to rebase to deal with the merge conflict?

@IgorMinar IgorMinar force-pushed the fix/node-buffer-exports branch from e4f5413 to 98b97f2 Compare May 31, 2024 14:41
@IgorMinar IgorMinar force-pushed the fix/node-buffer-exports branch from 98b97f2 to aac5416 Compare May 31, 2024 14:42
@IgorMinar
Copy link
Contributor Author

@jasnell done. please note that I had to add eslint-disable-next-line bailouts into the code because our current typescript setup is not great, or at least I couldn't figure out how to make it all work with our custom d.ts files.

I suspect that we should really be using @types/node instead of our custom typings here but that was a much bigger change that I was willing to bite off in this PR.

@IgorMinar IgorMinar merged commit 4d6864a into cloudflare:main May 31, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 expose btoa and atob via node:buffer
2 participants