V8 Updates: Migrate to v8::Object::Wrap/Unwrap #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentonv
reviewed
May 22, 2024
jasnell
force-pushed
the
jsnell/embedder-field-refactor
branch
from
a8de96b to
66cb668
Compare
jasnell
changed the title
kentonv
approved these changes
May 24, 2024
jasnell
force-pushed
the
jsnell/embedder-field-refactor
branch
from
66cb668 to
8266e11
Compare
v8 is simplifying the way embedder apis connect to wrapper JS objects.
jasnell
force-pushed
the
jsnell/embedder-field-refactor
branch
from
8266e11 to
5630432
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v8 is simplifying the way embedder apis connect to wrapper JS objects.
This attempts to keep the necessary changes as minimal as possible.
Note that with the move to
v8::Object::Wrap/Unwrap, we ought to be able to eliminate the special handling of the context global wrapper and simplify things a bit further, but that's bit of a larger change. Will save that for a separate PR.