Account for CR in prepared statements, add tests #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
Oct 20, 2023
jasnell
approved these changes
Oct 20, 2023
vickykont
reviewed
Oct 26, 2023
kentonv
approved these changes
Nov 6, 2023
|
Users are somewhat regularly still hitting this in the Discord - is there anything left before this can be merged? |
fhanau
approved these changes
Jul 4, 2024
ns476
pushed a commit
to ns476/workerd
that referenced
this pull request
Aug 2, 2024
…cloudflare#1322) * Account for CR in prepared statements tail, add tests * Add additional whitespace characters * Add \r\n into whitespace test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1300
This PR adds
\rinto the logic that makes sure there is nothing more than whitespace at the end of a prepared statement, otherwise it will throw an error indicating that a prepared statement can only contain one statement.Accompanying tests have been added to make sure that spaces, CR, LF and CRLF are accepted as whitespace as well that multiple statements are rejected.