Fix stack-use-after-scope in workerd-api

cloudflare · Dec 4, 2024 · 890243a · 890243a
1 parent 720f4e3
commit 890243a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/workerd/server/tests/python/BUILD.bazel b/src/workerd/server/tests/python/BUILD.bazel
@@ -34,6 +34,10 @@ py_wd_test(
         ],
         exclude = ["**/*.wd-test"],
     ),
+    tags = [
+        # TODO(someday): Fix asan failure for this, see https://github.com/cloudflare/workerd/pull/3140#discussion_r1858273318
+        "no-asan",
+    ],
 )
 
 py_wd_test(

diff --git a/src/workerd/server/workerd-api.c++ b/src/workerd/server/workerd-api.c++
@@ -468,8 +468,8 @@ void writePyodideBundleFileToDisk(const kj::Maybe<kj::Own<const kj::Directory>>&
 
 kj::Maybe<jsg::Bundle::Reader> fetchPyodideBundle(
     const api::pyodide::PythonConfig& pyConfig, kj::StringPtr version) {
-  KJ_IF_SOME(version, pyConfig.pyodideBundleManager.getPyodideBundle(version)) {
-    return version;
+  if (pyConfig.pyodideBundleManager.getPyodideBundle(version) != kj::none) {
+    return pyConfig.pyodideBundleManager.getPyodideBundle(version);
   }
 
   auto maybePyodideBundleFile = getPyodideBundleFile(pyConfig.pyodideDiskCacheRoot, version);