Merge pull request #3171 from cloudflare/yagiz/add-dns-constants

add node:dns constants

src/node/BUILD.bazel

@@ -13,6 +13,7 @@ wd_ts_bundle(
         "*.ts",
         "*.js",
         "assert/*.ts",
+        "dns/*.ts",
         "stream/*.js",
         "path/*.ts",
         "util/*.ts",

src/node/dns.ts

@@ -1,4 +1,7 @@
 import { default as dnsUtil } from 'node-internal:dns';
+import * as errorCodes from 'node-internal:internal_dns_constants';
+
+export * from 'node-internal:internal_dns_constants';
 
 export const getServers = dnsUtil.getServers.bind(dnsUtil);
 export const lookup = dnsUtil.lookup.bind(dnsUtil);
@@ -44,4 +47,6 @@ export default {
   setDefaultResultOrder,
   getDefaultResultOrder,
   setServers,
+
+  ...errorCodes,
 };

src/node/dns/promises.ts

@@ -0,0 +1,7 @@
+import * as errorCodes from 'node-internal:internal_dns_constants';
+
+export * from 'node-internal:internal_dns_constants';
+
+export default {
+  ...errorCodes,
+};

src/node/internal/internal_dns_constants.ts

@@ -0,0 +1,24 @@
+export const NODATA = 'ENODATA';
+export const FORMERR = 'EFORMERR';
+export const SERVFAIL = 'ESERVFAIL';
+export const NOTFOUND = 'ENOTFOUND';
+export const NOTIMP = 'ENOTIMP';
+export const REFUSED = 'EREFUSED';
+export const BADQUERY = 'EBADQUERY';
+export const BADNAME = 'EBADNAME';
+export const BADFAMILY = 'EBADFAMILY';
+export const BADRESP = 'EBADRESP';
+export const CONNREFUSED = 'ECONNREFUSED';
+export const TIMEOUT = 'ETIMEOUT';
+export const EOF = 'EOF';
+export const FILE = 'EFILE';
+export const NOMEM = 'ENOMEM';
+export const DESTRUCTION = 'EDESTRUCTION';
+export const BADSTR = 'EBADSTR';
+export const BADFLAGS = 'EBADFLAGS';
+export const NONAME = 'ENONAME';
+export const BADHINTS = 'EBADHINTS';
+export const NOTINITIALIZED = 'ENOTINITIALIZED';
+export const LOADIPHLPAPI = 'ELOADIPHLPAPI';
+export const ADDRGETNETWORKPARAMS = 'EADDRGETNETWORKPARAMS';
+export const CANCELLED = 'ECANCELLED';

src/node/tsconfig.json

@@ -24,6 +24,7 @@
     "paths": {
       "node:*": ["./*"],
       "node:assert/*": ["./*"],
+      "node:dns/*": ["./*"],
       "node:util/*": ["./*"],
       "node:path/*": ["./*"],
       "node:stream/*": ["./*"],

src/workerd/api/node/tests/dns-nodejs-test.js

@@ -1,4 +1,5 @@
 import dns from 'node:dns';
+import dnsPromises from 'node:dns/promises';
 import { strictEqual } from 'node:assert';
 
 export const functionsExist = {
@@ -29,3 +30,10 @@ export const functionsExist = {
     }
   },
 };
+
+export const errorCodesExist = {
+  async test() {
+    strictEqual(typeof dns.NODATA, 'string');
+    strictEqual(typeof dnsPromises.NODATA, 'string');
+  },
+};