Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add valid values to cloudflare_turnstile_widget.mode doc #2424

Merged
merged 2 commits into from
May 10, 2023

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented May 9, 2023

Fixes #2417

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/contributing/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included, please add the workflow/skip-changelog-entry label.

@LinusU
Copy link
Contributor Author

LinusU commented May 9, 2023

@jacobbednarz could you add the workflow/skip-changelog-entry tag?

Changes that should not have a CHANGELOG entry

  • Resource and provider documentation updates

ref: https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/contributing/changelog-process.md#changes-that-should-not-have-a-changelog-entry

@jacobbednarz
Copy link
Member

thanks but the PR is targeting the generated artifacts that will be overwritten next run. check out https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/contributing/registry-documentation.md for how to update these files and have them stick.

@LinusU
Copy link
Contributor Author

LinusU commented May 9, 2023

Hmm, seems like the best thing would be if the documentation generator could look at the stringvalidator.OneOf validator and do this automatically? 🤔

I've added the text to MarkdownDescription now 🚀

@jacobbednarz
Copy link
Member

Hmm, seems like the best thing would be if the documentation generator could look at the stringvalidator.OneOf validator and do this automatically? 🤔

this is a known restriction of the plugin framework. it is already tracked upstream via hashicorp/terraform-plugin-framework#625

@jacobbednarz jacobbednarz added the workflow/skip-changelog-entry Denotes an issue or PR does not require a changelog entry to be added before merging. label May 10, 2023
@jacobbednarz jacobbednarz merged commit 995085a into cloudflare:master May 10, 2023
@github-actions github-actions bot added this to the v4.6.0 milestone May 10, 2023
@jacobbednarz
Copy link
Member

thanks for this one @LinusU 🏆

@LinusU LinusU deleted the turnstile-mode-doc branch May 10, 2023 02:27
@LinusU
Copy link
Contributor Author

LinusU commented May 10, 2023

Thanks for the quick pull!

btw. do you know approximately when #2413 will be released? I ran into basically all issues covered by that one and had to terraform state rm to recover, and I would imagine that anyone else trying to use Turnstile via Terraform would have the same problems...

@jacobbednarz
Copy link
Member

the release process (including how to calculate the next one) is documented at https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/contributing/release-process.md.

if you need to use an unreleased version of the provider, there is also some steps you can use from https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/contributing/using-non-released-versions.md to run whatever version you're after.

@github-actions
Copy link
Contributor

This functionality has been released in v4.6.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
workflow/skip-changelog-entry Denotes an issue or PR does not require a changelog entry to be added before merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turnstile mode valid values not documented
2 participants