breaking changes for 4.x

[jacobbednarz]

Tracking for all the planned cleanup in 4.x

Internal cleanup

• Remove all uses of UsingAccount in favour of explicit account ID parameters. (provider: remove account_id global configuration option #2139)
• Remove reliance on userBaseUrl.
• Remove all references to client.AccountID. (remove internal reliance on client.AccountID #2154)

Schema updates

• cloudflare_byo_ip_prefix prefix_id should be internal id, not a custom attribute.

Deletions/modifications

• cloudflare_spectrum_application needs to support a list of config options (not just IP list) in edge_ips (resource/cloudflare_spectrum_application: allow nesting of edge_ips #2219)
• cloudflare_zone to swap account_id to Required: true (from optional) (enforce account_id for resources that previously depended on global account_id #2153)
• cloudflare_load_balancer_pool to swap account_id to Required: true (from optional) (enforce account_id for resources that previously depended on global account_id #2153)
• cloudflare_load_balancer_monitor to swap account_id to Required: true (from optional) (enforce account_id for resources that previously depended on global account_id #2153)
• cloudflare_account_member to swap account_id to Required: true (from optional) (enforce account_id for resources that previously depended on global account_id #2153)
• cloudflare_workers_kv_namespace to swap account_id to Required: true (from optional) (enforce account_id for resources that previously depended on global account_id #2153)
• cloudflare_workers_kv to swap account_id to Required: true (from optional) (enforce account_id for resources that previously depended on global account_id #2153)
• cloudflare_workers_script to swap account_id to Required: true (from optional) (enforce account_id for resources that previously depended on global account_id #2153)
• remove ability to create user level resources
  • cloudflare_access_rule (resource/cloudflare_access_rule: remove ability to create user level rules #2157)
  • cloudflare_load_balancer (resource/cloudflare_access_rule: remove ability to create user level rules #2157)
  • cloudflare_load_balancer_monitor (resource/cloudflare_access_rule: remove ability to create user level rules #2157)
  • cloudflare_load_balancer_pool (resource/cloudflare_access_rule: remove ability to create user level rules #2157)

Additions

• cloudflare_zone needs to support account_id (account_id support for members and zone #1767)
• cloudflare_account_member needs to support account_id (account_id support for members and zone #1767)
• cloudflare_access_rule needs to support account_id (Access rules account_id support #1790)
• cloudflare_load_balancer_pool needs to support account_id (resource/cloudflare_load_balancer_{monitor,pool}: add support for explicit account_ids #1986)
• cloudflare_load_balancer_monitor needs to support account_id (resource/cloudflare_load_balancer_{monitor,pool}: add support for explicit account_ids #1986)
• cloudflare_workers_kv needs to support account_id (Bump github.com/cloudflare/cloudflare-go from 0.54.0 to 0.55.0 #2049)
• cloudflare_workers_kv_namespace needs to support account_id (Bump github.com/cloudflare/cloudflare-go from 0.54.0 to 0.55.0 #2049)
• cloudflare_worker_script needs to support account_id (Bump github.com/cloudflare/cloudflare-go from 0.56.0 to 0.57.0 #2102)
• cloudflare_worker_route needs to support account_id only supported at the zone level for now
• cloudflare_worker_cron_trigger needs to support account_id

Deprecations

• cloudflare_argo_tunnel => cloudflare_tunnel (resource/cloudflare_argo_tunnel: rename to cloudflare_tunnel #2135)
• Remove cloudflare_access_bookmark resource in favour of configuration on cloudflare_access_application (resource/cloudflare_access_bookmark: remove resource #2136).
• Legacy WAF configuration
  • cloudflare_waf_group (resource) (remove legacy WAF resources and data sources #2138)
  • cloudflare_waf_override (resource) (remove legacy WAF resources and data sources #2138)
  • cloudflare_waf_package (resource) (remove legacy WAF resources and data sources #2138)
  • cloudflare_waf_rule (resource) (remove legacy WAF resources and data sources #2138)
  • cloudflare_waf_groups (datasource) (remove legacy WAF resources and data sources #2138)
  • cloudflare_waf_packages (datasource) (remove legacy WAF resources and data sources #2138)
  • cloudflare_waf_rules (datasource) (remove legacy WAF resources and data sources #2138)
• cloudflare_ip_list (replaced by cloudflare_list) (resource/cloudflare_ip_list: removed in favour of cloudflare_list #2137)

[Nmishin]

Seems account_id should be added to the cloudflare_worker_script as well.
If I try to run terraform apply without export CLOUDFLARE_ACCOUNT_ID it fails with error:

│ Error: error creating worker script: account ID required
│ 
│   with module.workers.cloudflare_worker_script.main["cors"],
│   on .terraform/modules/workers/cloudflare/worker/main.tf line 17, in resource "cloudflare_worker_script" "main":
│   17: resource "cloudflare_worker_script" "main" {
│ 

[jacobbednarz]

thanks @Nmishin - added.

[NJITman]

1 addition:
cloudflare_load_balancer needs to support account_id

[jacobbednarz]

thanks, added.

[andy-paine-numan]

Another addition that needs account_id support - cloudflare_worker_route

[jacobbednarz]

Another addition that needs account_id support - cloudflare_worker_route

thanks, updated

[andrewkrain]

It seems that account_id was added to most account-level resources in 3.27.0. However, this doesn't seem to enforce the use of account-level API (unlike specifying account_id on provider level or using the CLOUDFLARE_ACCOUNT_ID environment variable, both of which are now deprecated).

[jacobbednarz]

@andrewkrain please open a new issue following the template provided for the resources you're having issues with so we can address those specifically and just link back to this larger tracking ticket.

[Cyb3r-Jak3]

Seems like ip_list should be deprecated in favor of list
https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/internal/provider/resource_cloudflare_ip_list.go#L15-L16

[jacobbednarz]

thanks @Cyb3r-Jak3; added.

[github-actions]

This functionality has been released in v4.0.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!