-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented route /v2/_catalog API functionality #19
Conversation
Thank you for your contribution! |
Anything else that I need to cover to merge this PR to the branch? |
It looks there is no more user namespace or special authentication involved here. Shouldn't catalog be restricted to a privileged user? |
Sorry forgot to submit my review :-). There are some comments I wanted to be addressed |
About @skepticfx mentioned authentication feature, @gabivlj do you know we should have restrictions for each user or just general authentication? |
Thank you @keyskull, I had another nit but once that is addressed I think all is ok to merge from my side. |
We have some kind of read/write permissions. IMO this is already handled on the middleware side. What do you think @skepticfx? |
@gabivlj registries don't allow access to this by default AFAIK. But I believe, this specific authorization check is not really relevant to this PR. Believe a middleware which does the right RBAC should handle this correctly. None of our middleware examples allow this today, but something to be cautious about. |
No description provided.