-
Notifications
You must be signed in to change notification settings - Fork 38
add environment variables and working directory support to command exec #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
whoiskatrin
wants to merge
15
commits into
main
Choose a base branch
from
fix-env-vars
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+444
−66
Open
Changes from 3 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a7bae24
add environment variables and working directory support to command ex…
whoiskatrin 00ff59e
add execution options support to test worker API endpoints
whoiskatrin 9ef41fe
improve environment variable handling in command execution
whoiskatrin 67ebcab
updates based on review
whoiskatrin 4238cb7
Merge remote-tracking branch 'origin/main' into fix-env-vars
whoiskatrin d69e436
Fix openai agents example typecheck
whoiskatrin a4ea45b
Add support for env vars and working directory in exec
whoiskatrin 39cf60b
minor fixes and nits
whoiskatrin a6f3209
one more nit
whoiskatrin abbb218
handling of environment variables in the session execution
whoiskatrin 32f744b
fix tests
whoiskatrin d9b18cb
update tests
whoiskatrin cad3f21
additional security and tests
whoiskatrin c0b8622
nits
whoiskatrin 510fe63
fix handling of environment variable exports in session management
whoiskatrin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -142,7 +142,10 @@ describe('Sandbox - Automatic Session Management', () => { | |
|
|
||
| expect(sandbox.client.commands.execute).toHaveBeenCalledWith( | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TEST BUG: This test expectation doesn't match the actual implementation. Actual signature from command-client.ts:40-48: execute(command: string, sessionId: string, options?: {...})This test expects 5 parameters: .toHaveBeenCalledWith(
'echo test',
expect.stringMatching(/^sandbox-/),
undefined, // These three undefined params are wrong
undefined,
undefined
)Should be: .toHaveBeenCalledWith(
'echo test',
expect.stringMatching(/^sandbox-/),
undefined // Single options parameter
)Or to be more robust: .toHaveBeenCalledWith(
'echo test',
expect.stringMatching(/^sandbox-/),
expect.anything()
)Multiple tests have this same issue (lines 148-154, 290-296, 399-406). All need fixing. |
||
| 'echo test', | ||
| expect.stringMatching(/^sandbox-/) | ||
| expect.stringMatching(/^sandbox-/), | ||
| undefined, | ||
| undefined, | ||
| undefined | ||
| ); | ||
| }); | ||
|
|
||
|
|
@@ -284,7 +287,10 @@ describe('Sandbox - Automatic Session Management', () => { | |
|
|
||
| expect(sandbox.client.commands.execute).toHaveBeenCalledWith( | ||
| 'echo test', | ||
| 'isolated-session' | ||
| 'isolated-session', | ||
| undefined, | ||
| undefined, | ||
| undefined | ||
| ); | ||
| }); | ||
|
|
||
|
|
@@ -387,7 +393,10 @@ describe('Sandbox - Automatic Session Management', () => { | |
| await session.exec('pwd'); | ||
| expect(sandbox.client.commands.execute).toHaveBeenCalledWith( | ||
| 'pwd', | ||
| 'test-session' | ||
| 'test-session', | ||
| undefined, | ||
| undefined, | ||
| undefined | ||
| ); | ||
| }); | ||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.