Reuse Docker container between reloads, closes #369 #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my machine, this change reduces reload time from ~1.5s to ~400ms
Deploying with
|
| Latest commit: |
7da20b6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1759449a.cf-miniflare.pages.dev |
| Branch Preview URL: | https://tre-reuse-docker.cf-miniflare.pages.dev |
penalosa
requested changes
Sep 15, 2022
|
|
||
| function waitForExit(process: childProcess.ChildProcess): Promise<number> { | ||
| function waitForExit(process: childProcess.ChildProcess): Promise<void> { |
There was a problem hiding this comment.
Why the change from void to number?
There was a problem hiding this comment.
This allows us to return #processExitPromise directly from dispose() without an await. We weren't actually using the exit code anywhere, though perhaps we should be logging it if verbose is enabled?
penalosa
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating a new container whenever we change the config, we now start a single container with a custom entrypoint script. On receiving
SIGUSR1, this script restarts the runtime process. This change reduces reload time from ~1.5s to ~400ms on my machine.