Add support for text_blobs
#228
Conversation
There was a problem hiding this comment.
Looks pretty bang on to me! 🙂Added a few comments. If you could add some tests here too that would be awesome: https://github.com/cloudflare/miniflare/blob/master/packages/core/test/plugins/bindings.spec.ts.
| textBlobBindings: { | ||
| D: loremIpsumPath, | ||
| }, |
There was a problem hiding this comment.
The idea with this test is that the lowest priority binding defines the most bindings, that are then overriden by subsequent higher priority bindings. For textBlobBindings, you'd want to define A, B, C as loremIpsumPath, for wasmBindings you'd define A, B, C, D, for envPath you'd define A=env\nB=env\nC=env\nD=env\nE=env and then for wrangler bindings you'd define A, B, C, D, E, F.
This is probably a little excessive, but it's nice to test every combination 🙂
This adds support for `text_blobs`/Text module support in local mode. Now that cloudflare/miniflare#228 has landed in miniflare (thanks @caass!), we can use that in wrangler as well. Fixes #416
This adds support for `text_blobs`/Text module support in local mode. Now that cloudflare/miniflare#228 has landed in miniflare (thanks @caass!), we can use that in wrangler as well. Fixes #416
This adds support for `text_blobs`/Text module support in local mode. Now that cloudflare/miniflare#228 has landed in miniflare (thanks @caass!), we can use that in wrangler as well. Fixes #416
This adds support for `text_blobs`/Text module support in local mode. Now that cloudflare/miniflare#228 has landed in miniflare (thanks @caass!), we can use that in wrangler as well. Fixes #416
…ode (#735) This adds support for `text_blobs`/Text module support in local mode. Now that cloudflare/miniflare#228 has landed in miniflare (thanks @caass!), we can use that in wrangler as well. Fixes #416
I have absolutely no idea what I'm doing here 😎
Opening in hope of closing #211