Bind this name to the webcrypto
#216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in nodejs/node#4178 (which released in node v17.7.0) makes the [type check](https://github.com/nodejs/node/blob/master/lib/internal/crypto/webcrypto.js#L701-L703) on `this` in the internal `crypto` module fail.
|
I ran into this issue as well. This PR resolved it for me. |
|
Same issue here with this fix working as well! |
mrbbot
approved these changes
Mar 30, 2022
|
Hey! 👋 I've just released version |
This was referenced May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in nodejs/node#4178 (released in node v17.7.0) makes the type check on
thisin the internalcryptomodule fail.