Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "content-length: 0" from some requests #204

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Remove "content-length: 0" from some requests #204

merged 1 commit into from
Mar 8, 2022

Conversation

orls
Copy link
Contributor

@orls orls commented Mar 7, 2022

Fixes #193

mrbbot
mrbbot reviewed Mar 7, 2022
View reviewed changes
Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! 👋 Thanks for the PR! And a test too! 😍
A couple very minor things, then I'll merge.

packages/core/test/standards/http.spec.ts Outdated Show resolved Hide resolved
packages/core/src/standards/http.ts Outdated Show resolved Hide resolved
@orls orls force-pushed the fix-undici-contentlength-0 branch from d6ce875 to 2db1ff7 Compare March 8, 2022 10:16
@orls
Copy link
Contributor Author

orls commented Mar 8, 2022

Thanks; fixed the nits!

@mrbbot mrbbot merged commit 7280c52 into cloudflare:master Mar 8, 2022
@mrbbot mrbbot added this to the 2.4.0 milestone Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbbot mrbbot mrbbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

Behaviour mismatch: Fetch with content-length: 0 fails with undici error
2 participants
@orls @mrbbot