Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Svelte build directory #1970

Closed
wants to merge 1 commit into from
Closed

fix: update Svelte build directory #1970

wants to merge 1 commit into from

Conversation

vwkd
Copy link
Contributor

@vwkd vwkd commented Aug 5, 2021

Svelte build directory changed from /build to /.svelte-kit/static/build sveltejs/kit#2082

@vwkd vwkd requested review from a team as code owners August 5, 2021 04:39
@lukeed
Copy link
Contributor

lukeed commented Aug 5, 2021

Thanks for this. I'd suggest pinning to 1.0.0-next.36 right now as (I'm hoping) this change might be reverted.

Holding off on merging until this is decided concretely one way or another.

@benmccann
Copy link
Contributor

benmccann commented Aug 5, 2021

PR merged to change it back: sveltejs/kit#2109

@KimJ15 KimJ15 added the product:workers Related to Workers product label Aug 5, 2021
@KimJ15 KimJ15 added this to the Pages and Workers milestone Aug 5, 2021
@lukeed
Copy link
Contributor

lukeed commented Aug 5, 2021

Thank you @benmccann 🙏

And thank you @vwkd – since this change was reverted, there's no longer a need for this PR. Appreciate you bringing attention to this & submitting a fix so quickly

@lukeed lukeed closed this Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:workers Related to Workers product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants