Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WC-2955 Add documentation for serve_directly usage #18508

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

WillTaylorDev
Copy link
Contributor

Summary

Provides documentation for the serve_directly configuration option for Worker assets.

Documentation checklist

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, 1 total issue(s) found.

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/wc-2955-serve_directly-docs branch from 36f1356 to 4db0d3c Compare December 2, 2024 18:40
Copy link

cloudflare-workers-and-pages bot commented Dec 2, 2024

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 033ea81
Status: ✅  Deploy successful!
Preview URL: https://2d4fc001.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://willtaylor-wc-2955-serve-dir.cloudflare-docs-7ou.pages.dev

View logs

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/wc-2955-serve_directly-docs branch from 4db0d3c to 087d687 Compare December 2, 2024 18:57
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, 2 total issue(s) found.

@github-actions github-actions bot added product:workers Related to Workers product size/m labels Dec 2, 2024
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/wc-2955-serve_directly-docs branch from 087d687 to d838b19 Compare December 2, 2024 20:27
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, 2 total issue(s) found.


Note: We resolved prior Hyperlint review comments because:

We updated our inline suggestion AI.

We do this to avoid keeping outdated or irrelevant comments around. We'll leave a new review with current comments below.

Copy link
Contributor

@GregBrimble GregBrimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold off until everything is live in prod. And yeah, maybe let product have a pass. But LGTM!

@WillTaylorDev WillTaylorDev marked this pull request as draft December 3, 2024 17:07
@WillTaylorDev
Copy link
Contributor Author

Drafting for now-- floating around internally for feedback.

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/wc-2955-serve_directly-docs branch from d838b19 to 510608e Compare December 9, 2024 14:50
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, 2 total issue(s) found.

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/wc-2955-serve_directly-docs branch 2 times, most recently from 72684c6 to c4bc385 Compare December 18, 2024 21:54
@WillTaylorDev WillTaylorDev marked this pull request as ready for review December 18, 2024 21:55
@WillTaylorDev WillTaylorDev requested a review from a team as a code owner December 18, 2024 21:55
Copy link
Contributor

@korinne korinne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/wc-2955-serve_directly-docs branch from c4bc385 to 033ea81 Compare December 19, 2024 13:42
@WillTaylorDev WillTaylorDev merged commit 1535d6e into production Dec 19, 2024
12 checks passed
@WillTaylorDev WillTaylorDev deleted the willtaylor/wc-2955-serve_directly-docs branch December 19, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:workers Related to Workers product size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants