-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WC-2955 Add documentation for serve_directly usage #18508
WC-2955 Add documentation for serve_directly usage #18508
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 files reviewed, 1 total issue(s) found.
36f1356
to
4db0d3c
Compare
src/content/docs/workers/static-assets/compatibility-matrix.mdx
Outdated
Show resolved
Hide resolved
Deploying cloudflare-docs with
|
Latest commit: |
033ea81
|
Status: | ✅ Deploy successful! |
Preview URL: | https://2d4fc001.cloudflare-docs-7ou.pages.dev |
Branch Preview URL: | https://willtaylor-wc-2955-serve-dir.cloudflare-docs-7ou.pages.dev |
4db0d3c
to
087d687
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 files reviewed, 2 total issue(s) found.
087d687
to
d838b19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 files reviewed, 2 total issue(s) found.
Note: We resolved prior Hyperlint review comments because:
We updated our inline suggestion AI.
We do this to avoid keeping outdated or irrelevant comments around. We'll leave a new review with current comments below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hold off until everything is live in prod. And yeah, maybe let product have a pass. But LGTM!
Drafting for now-- floating around internally for feedback. |
d838b19
to
510608e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 files reviewed, 2 total issue(s) found.
72684c6
to
c4bc385
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
c4bc385
to
033ea81
Compare
Summary
Provides documentation for the serve_directly configuration option for Worker assets.
Documentation checklist