Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use untyped consts for Kyber params #398

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Use untyped consts for Kyber params #398

merged 1 commit into from
Feb 1, 2023

Conversation

tmthrgd
Copy link
Contributor

@tmthrgd tmthrgd commented Feb 1, 2023

These two constants are unnecessarily typed. This flows through all the way to the kem/kyber/kyberN packages where they cause PrivateKeySize and PublicKeySize to also be unnecessarily typed.

@tmthrgd tmthrgd changed the title Use untyped consts for Kyber Use untyped consts for Kyber params Feb 1, 2023
@bwesterb bwesterb requested a review from armfazh February 1, 2023 11:47
@bwesterb
Copy link
Member

bwesterb commented Feb 1, 2023

@armfazh This change should not break compatibility, but it will break compatibility if we need to reintroduce types on these constants for some reason later on. I don't have strong feelings either way. What do you think?

Copy link
Contributor

@armfazh armfazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are constants (rather than variables) then I think is safe to keep them untyped.

@armfazh armfazh merged commit 7a181da into cloudflare:main Feb 1, 2023
@tmthrgd tmthrgd deleted the untyped-kyber branch February 2, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants