bls12: replacing big.Int by fiat-crypto arithmetic. #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armfazh
changed the title
wbl
approved these changes
Jul 23, 2021
| // Code Generation using fiat-crypto | ||
| // | ||
| // Download and unpack `ExtractionOCaml-Ubuntu LTS` from | ||
| // https://github.com/mit-plv/fiat-crypto/suites/3241842351/artifacts/75305272 |
There was a problem hiding this comment.
Youch. This sounds like a fun time on the mac. Well, that's ok: we'll manage.
There was a problem hiding this comment.
The artifacts also contain the .ml files from which the binaries are built, so you could rebuild them from source. I can also get the Mac and Windows CIs to start uploading artifacts again; I seem to recall disabling them because it seemed that seemed plausibly related to the Mac CIs failing.
ecc/bls12381/gt.go
Outdated
| func (z *Gt) Mul(x, y *Gt) { (*ff.Fp12)(z).Mul((*ff.Fp12)(x), (*ff.Fp12)(y)) } | ||
| func (z *Gt) Sqr(x *Gt) { (*ff.Fp12)(z).Sqr((*ff.Fp12)(x)) } | ||
| func (z *Gt) Inv(x *Gt) { (*ff.Fp12)(z).Inv((*ff.Fp12)(x)) } | ||
| func (z Gt) String() string { return (ff.Fp12)(z).String() } |
There was a problem hiding this comment.
Gt isn't using cyclo6, which seems odd to me.
There was a problem hiding this comment.
take a look on the new approach.
This was referenced Jul 27, 2021
wbl
approved these changes
Jul 27, 2021
wbl
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates formal verified code from Erbsen et al. "Simple High-Level Code For Cryptographic Arithmetic – With Proofs, Without Compromises" fiat-crypto project.
Generator
Generation of code requires manual triggering for fetching fiat codebase, all instructions are in
ecc/bls12381/ff/gen.goGenerated files
Code generated targets prime field operations in Montgomery representation: addition, subtraction, multiplication, squaring.
ecc/bls12381/ff/fpMont381.gofor the base field.ecc/bls12381/ff/scMont255.gofor the scalar field.cc: @JasonGross