Add support for protobuf batch format #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskeet
approved these changes
Apr 2, 2021
JemDay
force-pushed
the
jd-proto-batch
branch
3 times, most recently
from
276b125 to
6aaa2c9
Compare
Update prototbuf format to define how batches of protobuf format events are represented. Signed-off-by: Day, Jeremy(jday) <[email protected]>
duglin
reviewed
Apr 8, 2021
|
|
||
| Although the _protobuf batch format_ builds on the _protobuf format_ it is considered | ||
| seperate, that is to say that support of _protobuf format_ does not indicate support | ||
| of the batch representation. The batch format MUST only be used where supported. |
There was a problem hiding this comment.
I'm not sure how to interpret that MUST. Is that a statement for the sender or receiver? How does the sender know?
There was a problem hiding this comment.
There's similar language in the JSON format specification .. the essence is that just because somebody claims to support cloudevents+json does NOT imply that they also support cloudevents-batch+json.
I can tweak the language a bit more if desired, or copy-paste from the JSON spec ;-)
|
Approved on the 4/8 call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add specification for protobuf batch format.
Extend protobuf format specification to include a batch format for protobuf.
Closes #794
Signed-off-by: Day, Jeremy(jday) [email protected]