Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #615 #616

Merged
merged 1 commit into from
May 21, 2020
Merged

Closes #615 #616

merged 1 commit into from
May 21, 2020

Conversation

fabiojose
Copy link
Contributor

Change CloudEvent to AvroCloudEvent

Signed-off-by: Fabio José [email protected]

Change CloudEvent to AvroCloudEvent

Signed-off-by: Fabio José <[email protected]>
@duglin
Copy link
Collaborator

duglin commented May 9, 2020

@fabiojose are these breaking changes? On the call this week there was concern that this would break existing users and that these changes are not simply changes to things like "docs" or "description" attribtues.

@fabiojose
Copy link
Contributor Author

@duglin yes! This is a break change.

@duglin
Copy link
Collaborator

duglin commented May 9, 2020

Should we make it then? Technically that would require a v2.0 of the Avro spec and is it really worth that just for a name change?

@fabiojose
Copy link
Contributor Author

@dug this PR does not change the attributes names, types or remove them.

This breaks the way someone uses with code generation tools, but at the end, the resulting event on the wire is the same.

BTW, should be prudent creating a version 1.1 of Avro schema.

@duglin
Copy link
Collaborator

duglin commented May 13, 2020

@fabiojose To be clear, you're saying that this does NOT require a major-version bump in the Avro spec?

Will an existing Avro client, or server, continue to work if the other side of the communication used this new file? Based on you saying it doesn't change what appears on the wire, I'm assuming the answer is 'yes'.

@duglin
Copy link
Collaborator

duglin commented May 21, 2020

Approved on the 5/14 call as a non-on-the-wire change and more akin to a bug that needs to be fixed.

@duglin duglin merged commit c745560 into cloudevents:master May 21, 2020
@duglin duglin mentioned this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants