Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce strictness in wording around Kafka < 0.10 data format #591

Closed
OneCricketeer opened this issue Mar 17, 2020 · 1 comment · Fixed by #1020
Closed

Reduce strictness in wording around Kafka < 0.10 data format #591

OneCricketeer opened this issue Mar 17, 2020 · 1 comment · Fixed by #1020

Comments

@OneCricketeer
Copy link

OneCricketeer commented Mar 17, 2020 •
edited
Loading

The Kafka spec states that the JSON format MUST be used for Kafka versions that do not support headers

Following #463, I'd simply say that any structured format that adheres to compatibility with the original JSON MUST be used. And that JSON COULD be used for human readability...

Lemme know your thoughts 😷
@duglin
Copy link
Collaborator

duglin commented Apr 25, 2020

hi @Cricket007, we discussed this on this week's call and agreed with you. Would you be willing to write-up a PR to address this? I think the current thinking was to just remove the and encode the event in JSON from the spec

duglin pushed a commit to duglin/spec that referenced this issue Jun 2, 2022
Remove hardcoded reference to JSON since we have Avro now
102cf5c 
Fixes cloudevents#591

Signed-off-by: Doug Davis <[email protected]>
@duglin duglin mentioned this issue Jun 2, 2022
Merged
duglin pushed a commit to duglin/spec that referenced this issue Jun 15, 2022
Remove hardcoded reference to JSON since we have Avro now
0f46a2f 
Fixes cloudevents#591

Signed-off-by: Doug Davis <[email protected]>
clemensv pushed a commit to clemensv/spec that referenced this issue Aug 19, 2022
Remove hardcoded reference to JSON since we have Avro now
ecf06b8 
Fixes cloudevents#591

Signed-off-by: Doug Davis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove hardcoded reference to JSON since we have Avro now duglin/spec
2 participants
@OneCricketeer @duglin