chore: cleanup codebase and fix flake errors #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th Black and modern Python anymore Signed-off-by: Yurii Serhiichuk <[email protected]>
Signed-off-by: Yurii Serhiichuk <[email protected]>
Signed-off-by: Yurii Serhiichuk <[email protected]>
Signed-off-by: Yurii Serhiichuk <[email protected]>
Signed-off-by: Yurii Serhiichuk <[email protected]>
Signed-off-by: Yurii Serhiichuk <[email protected]>
Signed-off-by: Yurii Serhiichuk <[email protected]>
Signed-off-by: Yurii Serhiichuk <[email protected]>
Signed-off-by: Yurii Serhiichuk <[email protected]>
Signed-off-by: Yurii Serhiichuk <[email protected]>
Signed-off-by: Yurii Serhiichuk <[email protected]>
xSAVIKx
force-pushed
the
feat/cleanup-toolings
branch
from
ca29801 to
1ab9b63
Compare
Signed-off-by: Yurii Serhiichuk <[email protected]>
xSAVIKx
force-pushed
the
feat/cleanup-toolings
branch
from
afbe450 to
000a8fb
Compare
for more information, see https://pre-commit.ci
Signed-off-by: Yurii Serhiichuk <[email protected]>
Signed-off-by: Yurii Serhiichuk <[email protected]>
for more information, see https://pre-commit.ci
|
@sasha-tkachev FYI. It's a bad practice to "export" APIs of the other modules from the current module (e.g. you were exporting |
|
@Klaudioz PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have cleaned up:
__init__.pyfiles export only API from the same or child modules (related to the recent feat: pydantic #182 PR).# noqaflake8 warnings.