add assertion helper for extension keys #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanmxa
force-pushed
the
br_assert
branch
2 times, most recently
from
81e4db0
to
91d4c02
Compare
Signed-off-by: myan <[email protected]>
Signed-off-by: myan <[email protected]>
Signed-off-by: myan <[email protected]>
embano1
reviewed
Jul 14, 2023
v2/test/event_matchers.go
Outdated
| @@ -184,6 +184,18 @@ func HasExtensions(ext map[string]interface{}) EventMatcher { | |||
| } | |||
| } | |||
|
|
|||
| // HasExtensionKeys checks if the event contain the provided keys from its extensions | |||
Signed-off-by: myan <[email protected]>
|
LGTM ping @lionelvillard for the merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved: #900