Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify doc NewCloudEventFromHTTPRequest -> NewEventFromHTTPRequest #836

Merged

Conversation

rnotorni
Copy link
Contributor

@rnotorni rnotorni commented Feb 6, 2023

#835

This pull request has a difference between the document and the implementation.

The document defines it as NewCloudEventFromHTTPRequest, but it is actually NewEventFromHTTPRequet.

@rnotorni rnotorni force-pushed the hotfix/issue835_NewEventFromHTTPRequest branch 2 times, most recently from 853cc8f to e121124 Compare February 6, 2023 07:52
@rnotorni rnotorni force-pushed the hotfix/issue835_NewEventFromHTTPRequest branch from e121124 to de1dfea Compare February 6, 2023 07:54
@rnotorni rnotorni changed the title Modify: Doc NewCloudEventFromHTTPRequest -> NewEventFromHTTPRequest Modify doc NewCloudEventFromHTTPRequest -> NewEventFromHTTPRequest Feb 6, 2023
Copy link
Member

@embano1 embano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duglin
Copy link
Contributor

duglin commented Apr 7, 2023

I can't figure out how to get github to rerun the tests - sigh.
Given this is just a docs change I'm going to merge it.
/LGTM

@duglin duglin merged commit da161f9 into cloudevents:main Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants