Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use errgroup to wait for subscribers in OpenInbound #600

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Use errgroup to wait for subscribers in OpenInbound #600

merged 1 commit into from
Oct 14, 2020

Conversation

ian-mi
Copy link
Contributor

@ian-mi ian-mi commented Oct 8, 2020

Fixes #599

@slinkydeveloper slinkydeveloper added this to the SDK 2.4 milestone Oct 9, 2020
n3wscott
n3wscott reviewed Oct 14, 2020
View reviewed changes
Copy link
Member

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n3wscott n3wscott merged commit 7bec7ba into cloudevents:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n3wscott n3wscott n3wscott left review comments

Assignees
No one assigned
Labels
bug Something isn't working component/protocol/pubsub
Projects
None yet
Milestone
SDK 2.4
Development

Successfully merging this pull request may close these issues.

Pubsub OpenInbound Infinite Loop on Context Cancellation
3 participants
@ian-mi @n3wscott @slinkydeveloper