[acp] Update default value of .fission.images.node #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudentity-ci
requested review from
a team,
mbilski and
holowinski
as code owners
cloudentity-ci
requested review from
artursmolarek,
lgonczarik,
jkotiuk,
ppodbielski-cloudentity and
lisocki
lgonczarik
requested changes
Jul 10, 2023
There was a problem hiding this comment.
@artursmolarek I think the industry standard is to keep values separated by empty lines (https://github.com/bitnami/charts/blob/main/bitnami/redis/values.yaml or whatever), so I think your logic should be adjusted a bit.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helm chart default value update
Description
This pull request has been created automatically.
We kindly request that you review and approve this pull request as soon as possible to ensure a seamless transition of these changes.