Skip to content

fix: [SDP-13171] Updating go-git version to latest to address securit… #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 1, 2024
Merged

fix: [SDP-13171] Updating go-git version to latest to address securit… #8

merged 4 commits into from
Feb 1, 2024

Conversation

@relaprolu
Copy link
Contributor

…y vulnerabilities

pinaki124
pinaki124 requested changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@pinaki124 pinaki124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will also need to update the destination here to look like this -

destination: ${{ vars.STAGING_DOCKER_REGISTRY }}/staging/configure-git-global-credentials:${{ cloudbees.scm.sha }}${{ cloudbees.scm.branch == 'main' && ',${{ vars.STAGING_DOCKER_REGISTRY }}/staging/configure-git-global-credentials:1.0.11,${{ vars.STAGING_DOCKER_REGISTRY }}/staging/configure-git-global-credentials:latest' || '' }} to make it consistent with all our other action workflows.

@relaprolu
Copy link
Contributor Author

You will also need to update the destination here to look like this -

destination: ${{ vars.STAGING_DOCKER_REGISTRY }}/staging/configure-git-global-credentials:${{ cloudbees.scm.sha }}${{ cloudbees.scm.branch == 'main' && ',${{ vars.STAGING_DOCKER_REGISTRY }}/staging/configure-git-global-credentials:1.0.11,${{ vars.STAGING_DOCKER_REGISTRY }}/staging/configure-git-global-credentials:latest' || '' }} to make it consistent with all our other action workflows.

Done

@relaprolu relaprolu merged commit 7a82050 into main Feb 1, 2024
@relaprolu relaprolu deleted the SDP-13171 branch February 1, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinaki124 pinaki124 pinaki124 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@relaprolu @pinaki124