CBP-18409 using the new git-credential-cloudbees #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sraybee
reviewed
Oct 17, 2025
There was a problem hiding this comment.
Pull Request Overview
Implements support for the new git-credential-cloudbees helper with fallback to the legacy helper when the new binary is not available.
- Detects git-credential-cloudbees on PATH and conditionally configures credentials.
- Adds internal Debug logging utility gated by RUNNER_DEBUG.
- Introduces invokeGitCredentialsHelper to initialize and configure the new helper.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| internal/util.go | Adds a Debug helper that prints messages when RUNNER_DEBUG=1. |
| internal/configuration/config.go | Detects and invokes git-credential-cloudbees, adds fallback logic, and wires up helper initialization and config updates. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cb-nsrinivasa
force-pushed
the
CBP-18409
branch
from
b5567c3 to
f670ab6
Compare
pinaki124
reviewed
Oct 21, 2025
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
pinaki124
approved these changes
Oct 22, 2025
pinaki124
approved these changes
Oct 23, 2025
sraybee
reviewed
Oct 23, 2025
internal/configuration/config.go
Outdated
| for _, filterGitUrl := range filterGitUrls { | ||
| filterUrlArgs = append(filterUrlArgs, "--filter-git-urls", filterGitUrl) | ||
| } | ||
| cmd := exec.CommandContext(ctx, path, filterGitUrls...) |
There was a problem hiding this comment.
Should this not be cmd := exec.CommandContext(ctx, path, filterUrlArgs...) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://cloudbees.atlassian.net/browse/CBP-18409
similar to cloudbees-io/checkout#41
if
git-credential-cloudbeesexists in PATH use it else defer to older impl