-
Notifications
You must be signed in to change notification settings - Fork 1
CBP-18302: allow absolute URL in repository input #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...instead of supporting only short form syntax (`{owner}/{repo}`)
Fixes a bug where the workflow originating repository URL was used to generate the `commit-url` output when the SCM `provider` was set to `bitbucket_datacenter` instead of using the `bitbucket-server-url` in that case.
|
I rebased the PR now to include #41. |
bb8407a to
5c96473
Compare
|
While e2e testing the action I realized that the logic that uses the commit SHA the workflow originates from as commit SHA of the repo to checkout by default when the checkout action's I'll also add corresponding e2e tests to the workflow within this repository... |
Don't modify the original repository input value when normalizing it but store the normalized representation within a separate internal field. This is so that the logic that derives the ref from the event when the repository input value equals the one within the event does not break.
|
Instead of normalizing the repo URL from the SCM event before comparing it with the |
...by adding a missing slash in front of the path
...instead of supporting only the short form syntax (
{owner}/{repo})Additional changes:
commit-urloutput value was generated when cloning a repository from Bitbucket Datacenter (the workflow originating SCM provider URL was always used as base URL instead of using thebitbucket-server-urlvalue and there was a missing slash).