This repository has been archived by the owner on Mar 11, 2022. It is now read-only.
Cookie persistence workaround #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlaver
approved these changes
Sep 14, 2021
| // 1. supplied now argument | ||
| // 2. this.creation (original cookie creation time) | ||
| // 3. current time | ||
| // This patch replaces 2 with an expiry check relative to the cloudantPatchUpdateTime if set instead of |
There was a problem hiding this comment.
did you mean:
Suggested change
| // This patch replaces 2 with an expiry check relative to the cloudantPatchUpdateTime if set instead of | |
| // This patch replaces 2 with an expiry check relative to the cloudantPatchUpdateTime instead of |
There was a problem hiding this comment.
No, it only compares it to the cloudantPatchUpdateTime if it is set.
mojito317
approved these changes
Sep 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGES.md|CHANGELOG.md) or test/build only changesDescription
Patch tough-cookie bug in TokenManager
Fixes #463
Approach
Patch the cookie jar used in the
TokenManagerwith the workaround for sliding updates intough-cookie. This is mostly the same patch we used incloudant-node-sdkjust with a slight change to the initial_jarchecks to suit therequestmodule.Schema & API Changes
Security and Privacy
Testing
Monitoring and Logging