Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug build triple-faulting on KVM #70

Closed
liuw opened this issue Oct 23, 2020 · 0 comments · Fixed by #72
Closed

Debug build triple-faulting on KVM #70

liuw opened this issue Oct 23, 2020 · 0 comments · Fixed by #72

Comments

@liuw
Copy link
Member

liuw commented Oct 23, 2020

Commit 12a3c21

Build with cargo build --target target.json -Zbuild-std=core -Zbuild-std-features=compiler-builtins-mem.

Run the resulting hypervisor-fw binary. It triple-faults.

After digging a bit, the faulting line is

rust-hypervisor-firmware/src/fat.rs

Line 213 in 12a3c21

s.copy_from_slice(unsafe { &lfns[i].name[..] });

0.2.8 debug build is okay.
rbradford added a commit to rbradford/rust-hypervisor-firmware that referenced this issue Oct 27, 2020
@rbradford
fat: Don't reference packed fields
ec77fd4 
This is undefined behaviour:
rust-lang/rust#46043

Fixes: cloud-hypervisor#70

Signed-off-by: Rob Bradford <[email protected]>
@rbradford rbradford mentioned this issue Oct 27, 2020
Merged
rbradford added a commit that referenced this issue Oct 27, 2020
@rbradford
fat: Don't reference packed fields
a04fa80 
This is undefined behaviour:
rust-lang/rust#46043

Fixes: #70

Signed-off-by: Rob Bradford <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fat: Don't reference packed fields rbradford/rust-hypervisor-firmware
1 participant
@liuw