Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor test suite #4637

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Refactor test suite #4637

merged 1 commit into from
Nov 5, 2024

Conversation

drewbo
Copy link
Contributor

@drewbo drewbo commented Oct 28, 2024 •
edited
Loading

Changes proposed in this pull request:

security considerations

None

@drewbo drewbo force-pushed the refactor-test-suite branch 2 times, most recently from 5a605a3 to e83b92f Compare October 28, 2024 19:39
@drewbo drewbo requested a review from a team October 28, 2024 21:01
@drewbo drewbo force-pushed the refactor-test-suite branch 3 times, most recently from 138c163 to d0ed899 Compare November 5, 2024 14:46
apburnes
apburnes reviewed Nov 5, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
apburnes
apburnes reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@apburnes apburnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a solid start for adding RTL tests. I put in just a few questions.

frontend/pages/sites/$siteId/builds/CreateBuildLink.jsx Show resolved Hide resolved
frontend/shared/ExpandableArea.test.jsx Show resolved Hide resolved
@drewbo drewbo requested a review from a team November 5, 2024 17:24
@drewbo drewbo force-pushed the refactor-test-suite branch from d0ed899 to a6232d7 Compare November 5, 2024 17:37
@drewbo drewbo merged commit bc81627 into main Nov 5, 2024
8 checks passed
@drewbo drewbo deleted the refactor-test-suite branch November 5, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apburnes apburnes apburnes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a partial RTL-based testing suite to be run in conjunction with existing test suite
2 participants
@drewbo @apburnes