Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RTL tests to @shared/GithubAuthButton.jsx #4671

Closed
7 tasks
Tracked by #4014
apburnes opened this issue Nov 20, 2024 · 0 comments · Fixed by #4687
Closed
7 tasks
Tracked by #4014

Add RTL tests to @shared/GithubAuthButton.jsx #4671

apburnes opened this issue Nov 20, 2024 · 0 comments · Fixed by #4687
Assignees
@apburnes @sknep
Labels
squad-pages

Comments

@apburnes
Copy link
Contributor

apburnes commented Nov 20, 2024 •
edited
Loading

Add a test to @shared/GithubAuthButton.jsx using the RTL framework. See our docs for writing frontend tests.

Acceptance Criteria

  • Colocate test file to @shared/GithubAuthButton.test.jsx
  • Test the text is displayed
  • Test the component opens an auth window with the correct url
  • Test the revokeFirst function is called on click
  • Test the onSuccess action gets called success
  • Test the onFailuer action gets called when fail
  • Remove component defaultProps and add the to the component args
@apburnes apburnes mentioned this issue Dec 2, 2024
Open
apburnes added a commit that referenced this issue Dec 4, 2024
@apburnes
chore: Test shared/GithubAuthButton #4671
c6b38f6
@apburnes apburnes mentioned this issue Dec 4, 2024
Merged
apburnes added a commit that referenced this issue Dec 4, 2024
@apburnes
chore: Test shared/GithubAuthButton #4671
09b8e2b 
Signed-off-by: Andrew Burnes <[email protected]>
apburnes added a commit that referenced this issue Dec 4, 2024
@apburnes
chore: Test shared/GithubAuthButton #4671
944c53c 
Signed-off-by: Andrew Burnes <[email protected]>
apburnes added a commit that referenced this issue Dec 4, 2024
@apburnes
chore: Test shared/GithubAuthButton #4671
b7b2f02 
Signed-off-by: Andrew Burnes <[email protected]>
apburnes added a commit that referenced this issue Dec 6, 2024
@apburnes
chore: Test shared/GithubAuthButton #4671
c73ba0e 
Signed-off-by: Andrew Burnes <[email protected]>
apburnes added a commit that referenced this issue Dec 6, 2024
@apburnes
Merge pull request #4687 from cloud-gov/chore-test-shared/GithubAuthB…
1ea4031 
…utton-4671

chore: Test shared/GithubAuthButton #4671
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apburnes apburnes

@sknep sknep

Labels
squad-pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Test shared/GithubAuthButton #4671 cloud-gov/pages-core
2 participants
@apburnes @sknep